Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move Pay default values to model #3993

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 20, 2024

Follow up to #3987 (comment)

This PR moves the default values to their own function in model.ts.

@@ -164,3 +164,41 @@ export const validationSchema = object({
}),
govPayMetadata: govPayMetadataSchema,
});

export const getDefaultContent = (): Pay => ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a function so that useStore.getState().flowName is called when the component mounts and we have a flowName.

@DafyddLlyr DafyddLlyr marked this pull request as draft November 20, 2024 16:51
@DafyddLlyr DafyddLlyr requested a review from a team November 20, 2024 17:03
@DafyddLlyr DafyddLlyr marked this pull request as ready for review November 20, 2024 17:03
Copy link

github-actions bot commented Nov 20, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 1784294 into main Nov 21, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/pay-default-values branch November 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants